Fixed phpseclib\Net\SFTP constants used in write() method #6894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
\Magento\Framework\Filesystem\Io\Sftp
class was modified to use an updated phpseclib library in commit 1383a49The write method uses the constants
NET_SFTP_LOCAL_FILE
andNET_SFTP_STRING
that worked just fine prior the library update. Since the library has changed, these constants are outdated and the write method throws this:Notice: Use of undefined constant NET_SFTP_LOCAL_FILE - assumed 'NET_SFTP_LOCAL_FILE' in /var/www/releases/release-0/vendor/magento/framework/Filesystem/Io/Sftp.php on line 187
when trying to use it.
I modified the constants according the actual library used in Magento. Please refer to https://github.com/phpseclib/phpseclib/blob/master/phpseclib/Net/SFTP.php to verify correctness.
Regards.