Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AccountLock.php #6952

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Update AccountLock.php #6952

merged 1 commit into from
Dec 7, 2016

Conversation

klict
Copy link
Contributor

@klict klict commented Oct 11, 2016

fix for "Notice: Undefined index: lock_expires in vendor/magento/module-customer/Ui/Component/Listing/Column/AccountLock.php on line 44"

fix for "Notice: Undefined index: lock_expires in vendor/magento/module-customer/Ui/Component/Listing/Column/AccountLock.php on line 44"
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 11, 2016

CLA assistant check
All committers have signed the CLA.

@slavvka slavvka self-assigned this Oct 19, 2016
@slavvka slavvka added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept labels Oct 19, 2016
@slavvka
Copy link
Member

slavvka commented Oct 19, 2016

@klict, please cover your change with unit test.

@klict
Copy link
Contributor Author

klict commented Oct 19, 2016

i can't perform unit test right now. if you want to add the small fix you can do it but i really don't care if you don't add it.

@mmansoor-magento mmansoor-magento merged commit 1f5b15d into magento:develop Dec 7, 2016
mmansoor-magento pushed a commit that referenced this pull request Dec 7, 2016
[South] Bugs:
- MAGETWO-56072 [Performance] Image resize mechanism does not generate images of all necessary sizes
- MAGETWO-59904 [PR][Github] Update AccountLock.php #6952
- MAGETWO-53550 [Github][PR] Fix newsletter queue subscribers adding performance #4088
- MAGETWO-60047 [Porting] Error on adding address during checkout if add custom customer address attribute of file type - 2.2
- MAGETWO-56396 "Go Today" button in filter type date doesn`t apply value
- MAGETWO-59365 Countries list is not loaded if change customer website after country was selected
- MAGETWO-59924 File attribute doesn't have placeholder in admin
@Ctucker9233
Copy link

Still not included in 2.1.10

@ihor-sviziev
Copy link
Contributor

@Ctucker9233 this fix included to release 2.2.0. You could prepare backport PR to 2.1-develop branch if you want to see it fixed in one of next 2.1.x releases

@ihor-sviziev ihor-sviziev added Fixed in 2.2.x The issue has been fixed in 2.2 release line Release Line: 2.2 and removed Progress: needs update labels Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants