Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change getId() to getPaymentId() #7762

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

HirokazuNishi
Copy link
Contributor

@HirokazuNishi HirokazuNishi commented Dec 12, 2016

Both 2.1.2 and latest develop version cannot fetch payment transaction info via admin panel.

Environment:

  • Magento version: 2.1.2 and later.
  • Client OS: Windows, Mac, Linux
  • Browser: IE, FireFox, Chrome, Safari
  • MySQL: 5.6/5.7

How to reproduce:

  1. Implement payment integration module with fetch transaction information.
  2. Create order without transaction data (like check money, cod).
  3. Create order with transaction data (like credit card or others).
  4. Execute fetch transaction data from admin panel.
  5. Cannot load transaction info.

Issue reason:

Magento\Sales\Controller\Adminhtml\Transactions\Fetch tries to get Order Payment object on line 36 with $txn->getId(), but there is no assurance that transaction id is always same as payment id.

How to fix:

Change $txn->getId() to $txn->getPaymentId().

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 12, 2016

CLA assistant check
All committers have signed the CLA.

@vrann vrann self-assigned this Mar 13, 2017
@vrann vrann added this to the March 2017 milestone Mar 13, 2017
@magento-team magento-team merged commit ed7b80e into magento:develop Mar 23, 2017
@ishakhsuvarov
Copy link
Contributor

@HirokazuNishi Thank you for contributing!

magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 6, 2022
B2B-2379: Cart is being loaded twice in multiple graphql mutation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants