Setting proper resource name #7900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antonkril
approved these changes
Jan 9, 2017
|
what should I do to make the PR pass the CI tests ? |
|
@ddattee please fix the tests and push changes to the current branch |
|
Ok I'll see to update the tests asap. |
added 2 commits
April 4, 2017 11:42
The resource name for trans_email resource is inconsistent with the resource declared in config module. Therefore enabling role to access the resource does not allow the role to access the menu
ddattee
force-pushed
the
resource-config-email
branch
from
2c90299
to
d764c62
Compare
|
Everything ok now ? |
|
@ddattee looks good, thank you |
magento-team
pushed a commit
that referenced
this pull request
Apr 13, 2017
|
@ddattee thank you for your contribution to Magento 2 project |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 14, 2022
[Chaika] BugFix delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource name declared for 'trans_email' is inconsistent with the resource declared in config module.
Therefore enabling the resource 'trans_email' for a role does not allow the role to modify the resource.