Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set static html fragments as cacheable #8000

Merged
merged 4 commits into from
Feb 25, 2017
Merged

Set static html fragments as cacheable #8000

merged 4 commits into from
Feb 25, 2017

Conversation

paveq
Copy link
Contributor

@paveq paveq commented Dec 30, 2016

Fixes issue where some of static content (knockout templates) are retrieved again for every request from the server, depending on apache configuration. With this modification we no longer depend on specifics of environment apache configuration.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 30, 2016

CLA assistant check
All committers have signed the CLA.

@paveq
Copy link
Contributor Author

paveq commented Dec 30, 2016

I believe one failing integration test has nothing to do this with PR, and it related to something else.

@maghamed maghamed self-assigned this Feb 2, 2017
@paveq
Copy link
Contributor Author

paveq commented Feb 3, 2017

What do you think, should we also send Cache-Control public for html files?

<FilesMatch .*\.(ico|jpg|jpeg|png|gif|svg|js|css|swf|eot|ttf|otf|woff|woff2)$>
    Header append Cache-Control public
</FilesMatch>

@okorshenko okorshenko added this to the February 2017 milestone Feb 11, 2017
@maghamed maghamed self-requested a review February 13, 2017 14:25
@maghamed
Copy link
Contributor

We are accepting current pull request, but in future this behavior would be modified in Magento as Varnish should not be used for caching and serving static content as html, images, css and other media.
All these content types should be served from webserver cache (Nginx for example).

@paveq
Copy link
Contributor Author

paveq commented Feb 13, 2017

@maghamed Does not this relate to where Varnish layer is? In case of Varnish residing in the same server/DC not caching static content there can make sense, but what in case where Varnish layer in in the edge (eg. Fastly service) and used as CDN?

@okorshenko okorshenko self-assigned this Feb 24, 2017
@mmansoor-magento mmansoor-magento merged commit b36cb75 into magento:develop Feb 25, 2017
@okorshenko
Copy link
Contributor

@paveq Thank you for your contribution! PR number == 8000 :) Good catch!

magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 22, 2022
[Bluetooth] Community Pull Requests delivery - 2.4-develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants