Remove Zend1 db from captcha module #8402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okorshenko
approved these changes
Feb 7, 2017
|
@dmanners Thank you for updating Magento 2 code base with new version of the components!!! Great job! I will resolve conflict of composer.lock file for you |
|
@dmanners Thank you for upgrading Magento 2 code base. Your PR successfully merged to develop branch. It would be great to update other Magento modules to have better code consistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Zend1 has been in end of life for a while we should really migrate away from it. This pull request will remove the usage of the Zend1
Zend_Db_Exprclass from the Magento Captcha module.