add anonymize ip option for google analytics

[thomas-villagers]

Hi,

I implemented an option for anonymized ips with google analytics.
The section "Google Analytics" in the backend (Stores > Configuration, Sales > Google API) has a new field "Anonymize IP".

According to the value in Anonymize IP, the ga('send' ...)-call in the generated html is either

ga('send', 'pageview', {'anonymizeIp' : false});

or

ga('send', 'pageview', {'anonymizeIp' : true});

(see https://developers.google.com/analytics/devguides/collection/analyticsjs/ip-anonymization)

this is my first try to extend magento and i'm open to suggestions.

• thomas

[magento-cicd2]

All committers have signed the CLA.

[vrann]

@thomas-villagers Thank you for contribution.
Does it makes sense to set ip anonymization globally (for all hits)?
I.e.:

ga('set', 'anonymizeIp', true);

[thomas-villagers]

@vrann Yes, of course! Where would that be done? I could'nt find it in Ga.php.

[vrann]

Should you set it globally instead, here?

ga('set', 'anonymizeIp', true);

[vrann]

@thomas-villagers I've added the comment to the code, if you change it to set anonymization globally, it will be applied to other types of hits as well.

[vrann]

@thomas-villagers looks perfect

[ctadlock]

@vrann @thomas-villagers This code is broken, the negative case was never tested. The code is doing a string comparison of config.pageTrackingData.isAnonymizedIpActive. The string value "0" is true.

https://stackoverflow.com/questions/7615214/in-javascript-why-is-0-equal-to-false-but-when-tested-by-if-it-is-not-fals

[ctadlock]

Here is the correct fix. Someone should do a PR for this...