Remove zend json checkout #8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sking for the interface
…g standards and add a space after each comman in the function call
fooman
reviewed
Feb 9, 2017
| */ | ||
| public function __construct( | ||
| \Magento\Framework\View\Element\Template\Context $context, | ||
| \Magento\Customer\Model\Session $customerSession, | ||
| \Magento\Checkout\Model\Session $checkoutSession, | ||
| \Magento\Checkout\Model\CompositeConfigProvider $configProvider, | ||
| array $layoutProcessors = [], | ||
| \Magento\Framework\Serialize\Serializer\Json $serializer = null, |
There was a problem hiding this comment.
I think if you are adding a new optional param like this it should come last as you are trying to avoid breaking anything.
There was a problem hiding this comment.
Oh yeah thanks @fooman for catching that.
…g in the constructor
|
@dmanners thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Zend1 has been EOL we should consider removing Zend1 components in Magento2. In this pull request I am replacing the usage of Zend_Json with the Magento Framework lib's serializer json object.