Remove unused argument #8682
Merged
Remove unused argument #8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor::populateMappings
|
|
orlangur
approved these changes
Feb 26, 2017
| @@ -135,7 +135,7 @@ public static function populateAutoloader($rootDir, $initParams) | |||
| { | |||
| $dirList = self::createFilesystemDirectoryList($rootDir, $initParams); | |||
| $autoloadWrapper = AutoloaderRegistry::getAutoloader(); | |||
| Populator::populateMappings($autoloadWrapper, $dirList, new ComponentRegistrar()); | |||
| Populator::populateMappings($autoloadWrapper, $dirList); | |||
There was a problem hiding this comment.
Nice! All such occurrences may be found with static code analysis, added to my TODO :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populator::populateMappings(…) method signature declares two parameters but is passed three arguments in
App/Bootstrap::populateAutoloaderThe third parameter was removed from signature and body at: 39abd59 this PR suggests remove the third argument at the call site.