Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2: #8616 #8784

Merged
merged 5 commits into from
Jun 21, 2017
Merged

magento/magento2: #8616 #8784

merged 5 commits into from
Jun 21, 2017

Conversation

cavalier79
Copy link

@cavalier79 cavalier79 commented Mar 3, 2017

Unused mysql privileges required even if not used/not needed at all

  • removed REFERENCES and EVENT privileges from DbValidator (also in Test Unit).

Nino Aratari added 5 commits March 2, 2017 15:47
…nfig\SourceFactory::create() method is wrong

Fixed type in return comment
A PHPDoc comment for \Magento\Config\Model\Config\SourceFactory::create() method is wrong
The correct return parameter is  \Magento\Framework\Option\ArrayInterface
Magento\Catalog\Model\ResourceModel\AbstractResource::getAttributeRawValue() returns false negative
- fixed adding a strong check on return value
Magento\Catalog\Model\ResourceModel\AbstractResource::getAttributeRawValue() returns false negative
- fixed adding a strong check on return value
Unused mysql privileges required even if not used/not needed at all
- removed REFERENCES and EVENT privileges from DbValidator (also in Test Unit).
@orlangur
Copy link
Contributor

orlangur commented Mar 3, 2017

@cavalier79 please recreate your branch from mainline/develop so that it does not include changes from #8778 PR :)

@cavalier79
Copy link
Author

sorry.. mistake in committing! I'll fix asap

@maghamed maghamed self-requested a review March 6, 2017 09:44
@maghamed maghamed self-assigned this Mar 6, 2017
@maghamed maghamed added this to the March 2017 milestone Mar 22, 2017
@okorshenko okorshenko modified the milestones: March 2017, April 2017 Apr 2, 2017
@okorshenko okorshenko modified the milestones: April 2017, May 2017 May 9, 2017
@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Jun 15, 2017
@magento-team magento-team merged commit c268d58 into magento:develop Jun 21, 2017
magento-team pushed a commit that referenced this pull request Jun 21, 2017
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 8, 2024
…ment

[Bengals Team] Test Fixes and Automation Tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants