Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#8863: Malta zipcode validation incomplete #8909

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

mmacinko
Copy link

@mmacinko mmacinko commented Mar 16, 2017

Added one more pattern in Malta countryCode nod

Description

Added one more pattern and changed order of all others in MT zip codes list, here:
app/code/Magento/Directory/etc/zip_codes.xml on line 280
<code id="pattern_1" active="true" example="ABC 1234">^[a-zA-Z]{3}\s[0-9]{4}$</code>

Fixed Issues (if relevant)

  1. magento/magetno2#8863: Malta zipcode validation incomplete

Manual testing scenarios

  1. go to cart or checkout and insert ABC 1234. Validation pass.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 16, 2017
@ishakhsuvarov ishakhsuvarov added this to the March 2017 milestone Mar 16, 2017
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 16, 2017

CLA assistant check
All committers have signed the CLA.

@magento-team magento-team merged commit 847b95b into magento:develop Mar 17, 2017
@okorshenko
Copy link
Contributor

@mmacinko thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants