Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove context aggregation validation (see Issue #6114) #8955

Merged
merged 2 commits into from
Apr 30, 2017
Merged

Remove context aggregation validation (see Issue #6114) #8955

merged 2 commits into from
Apr 30, 2017

Conversation

Vinai
Copy link
Contributor

@Vinai Vinai commented Mar 21, 2017 •
edited by maghamed

Remove the context aggregation validation step as it enforces increased coupling between a child class and the parent class dependencies.

Description

Please see issue #6114 for a complete description of the issue.

Fixed Issues (if relevant)

  1. magento/magetno2#6114: Compilation enforces coupling to parent class Context contents

Manual testing scenarios

  1. See the "Steps to reproduce" description in Issue Compilation enforces coupling to parent class Context contents #6114

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Vinai Vinai mentioned this pull request Mar 21, 2017
Closed
@maghamed maghamed self-requested a review March 24, 2017 14:58
@maghamed maghamed self-assigned this Mar 24, 2017
maghamed
maghamed suggested changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@maghamed maghamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment into the initial GitHub issue - #6114 (comment)

@maghamed maghamed closed this Mar 24, 2017
@Vinai Vinai mentioned this pull request Mar 25, 2017
Closed
@maksek maksek reopened this Apr 17, 2017
@maghamed
Copy link
Contributor

Hi @Vinai sorry for delay.
I was in a rush with Imagine preparation and mine PTO after it.
Do you have a time to get back to this PR?

@Vinai
Copy link
Contributor Author

Vinai commented Apr 23, 2017

Rebased and all checks passed.

@maghamed maghamed added this to the April 2017 milestone Apr 24, 2017
@magento-team magento-team merged commit 2d4a335 into magento:develop Apr 30, 2017
magento-team pushed a commit that referenced this pull request Apr 30, 2017
@ishakhsuvarov
MAGETWO-67721: Remove context aggregation validation (see Issue #6114) …
2767e27 
…#8955
magento-team pushed a commit that referenced this pull request Apr 30, 2017
@ishakhsuvarov
Merge pull request #1074 from magento-engcom/develop-prs
d69525e 
[EngCom] Public Pull Requests

 - MAGETWO-67723: Add logging to contact us form #9343
 - MAGETWO-67721: Remove context aggregation validation (see Issue #6114) #8955
 - MAGETWO-68767: Use loadPlayer requirejs mapping #9414
 - MAGETWO-68770: Fix addIdFilter method #9400
@magento-team
Copy link
Contributor

@Vinai thank you for your contribution. Your Pull Request has been successfully merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maghamed maghamed maghamed approved these changes

Assignees

@maghamed maghamed

Labels
improvement
Projects
None yet
Milestone
April 2017
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vinai @maghamed @magento-team @maksek