Upgrade JS dependencies #9062
Merged
Upgrade JS dependencies #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omiroshnichenko
approved these changes
Apr 11, 2017
|
@Igloczek thank you for your contribution to Magento 2 project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade of all of JS dependencies required to run Grunt.js task. Some packages have BC due to major releases, so I had to adjust configuration.
I also changed accepted version range from
^to~, b/c it's safer to use only hotfix upgrades, than minor (extremely important when we are not maintaining any lockfile for these dependencies).Some tasks don't work, b/c was broken before changes i.e.
grunt styledocco:documentation.Some of them work just weird like
grunt replace:documentation, b/c on every run they add license comments, even it already are added, but also it's not related to packages upgrade.Nice things - styles compilation works faster 馃槈