Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getShippingAddress() to order interface (resolves #6919) #9125

Closed
wants to merge 4 commits into from
Closed

Add getShippingAddress() to order interface (resolves #6919) #9125

wants to merge 4 commits into from

Conversation

schmengler
Copy link
Contributor

@schmengler schmengler commented Apr 4, 2017

Description

Adding getShippingMethod() to the order interface, analogous to the existing getBillingMethod().

Fixed Issues (if relevant)

  1. API improvement: OrderInterface should have a getShippingAddress method #6919: API improvement: OrderInterface should have a getShippingAddress method API improvement: OrderInterface should have a getShippingAddress method #6919

Manual testing scenarios

  1. GET an order via API
  2. See if there is a "shipping_address"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Vinai Vinai self-assigned this Apr 4, 2017
@Vinai
Copy link
Contributor

Vinai commented Apr 4, 2017

Since it is a data object, each getter should have a matching setter.

@adragus-inviqa
Copy link
Contributor

adragus-inviqa commented Apr 4, 2017

@Vinai - Dunno. I wouldn't want setters in my interfaces. They invite mutability. Let the implementation figure it out, not the interface. You shouldn't really know or care that the implementation is a data object anyway.

@schmengler
Copy link
Contributor Author

For consistency, I added the setter as well

@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 21, 2017
@ishakhsuvarov
Copy link
Contributor

@schmengler Unfortunately, due to backward compatibility policy we can not accept this Pull Request now, as it modifies an interface.
Please use ShippingAssignment extension attribute to process shippingAddress.
Thanks.

@ishakhsuvarov ishakhsuvarov self-assigned this Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants