Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data deletion using the multiple delete command #9446

Merged
merged 1 commit into from
May 9, 2017
Merged

Fix data deletion using the multiple delete command #9446

merged 1 commit into from
May 9, 2017

Conversation

kenboy
Copy link
Member

@kenboy kenboy commented Apr 28, 2017 •
edited

Description

Use command

$ magento module:uninstall Prefix_Module1 Prefix_Module2

Deletion scripts do not work

Manual testing scenarios

  1. Install modules containing scripts for deletion (Setup/Uninstall.php file)
  2. Uninstall module use command magento module:uninstall Prefix_Module1 Prefix_Module2

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fix multiple deletion
1650652 
# Case
Use command
```
$ magento module:uninstall Prefix_Module1 Prefix_Module2
```
# Problem
Deletion scripts do not work
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 28, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this May 2, 2017
@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 2, 2017
@magento-team magento-team merged commit 1650652 into magento:develop May 9, 2017
magento-team pushed a commit that referenced this pull request May 9, 2017
@ishakhsuvarov
MAGETWO-68861: Fix data deletion using the multiple delete command #9446
76ebd3e
magento-team pushed a commit that referenced this pull request May 9, 2017
@ishakhsuvarov
Merge pull request #1085 from magento-engcom/develop-prs
b6fb045 
[EngCom] Public Pull Requests

 - MAGETWO-68979: Fix breadcrumbs extra space #9514
 - MAGETWO-68977: fix for Class Magento\Framework\Console\CLI not found in case sensitive scenarios #9539
 - MAGETWO-68861: Fix data deletion using the multiple delete command #9446
 - MAGETWO-67722: Add ability to inject exception code in LocalizedException #9363
@magento-team
Copy link
Contributor

@kenboy thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
None yet
Projects
None yet
Milestone
May 2017
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kenboy @magento-cicd2 @magento-team @edakhmetgareev @ishakhsuvarov