Flip the property assignments for _logger and _fetchStrategy in __wakeup #9618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@cykirsch could you please sign CLA so that we can proceed with this PR? Thank you |
cykirsch
force-pushed
the
bug-abstractdb-wake
branch
from
5a18bc4
to
b6dc664
Compare
|
@okorshenko It's ready, let me know if you need anything else. |
|
@cykirsch great! Thank you |
okorshenko
added
Progress: accept
improvement
and removed
Progress: needs update
labels
magento-team
pushed a commit
that referenced
this pull request
May 16, 2017
…rategy in __wakeup #9618
|
@cykirsch thank you for your contribution |
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
…rategy in __wakeup #9618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes here are self-explanatory. Just an obvious oversight when setting a couple class properties during
__wakeup. I found this while digging deep into a different bug, but I admit I have not taken the time to figure out what needs to be done to test this fix.Contribution checklist