Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing payment info template for PDF generation #9701

Merged
merged 1 commit into from
May 24, 2017
Merged

Add missing payment info template for PDF generation #9701

merged 1 commit into from
May 24, 2017

Conversation

cmuench
Copy link
Contributor

@cmuench cmuench commented May 19, 2017

Description

The adminhtml area contains a default template for all payment methods
which comes without an own payment info template.
If you generate a PDF by clicking the "Print PDF" button i.e. the
invoice generation you will see correct payment informations.
If you generate a PDF in frontend you have an empty payment info because
of the missing template. The info block is returning an empty string
instead.

Manual testing scenarios

  1. Create an order with "banktransfer" payment.
  2. Add an order and attach a PDF invoice (i.e. with an own module)
  3. Download the invoice.
  4. Payment info is empty

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

The adminhtml area contains a default template for all payment methods
which comes without an own payment info template.
If you generate a PDF by clicking the "Print PDF" button i.e. the
invoice generation you will see correct payment informations.
If you generate a PDF in frontend you have an empty payment info because
of the missing template. The info block is returning an empty string
instead.
@miguelbalparda miguelbalparda self-assigned this May 23, 2017
@miguelbalparda miguelbalparda added this to the May 2017 milestone May 23, 2017
@miguelbalparda
Copy link
Contributor

Thank you for your contribution @cmuench! When you say

If you generate a PDF in frontend

does that mean programatically?

@vrann
Copy link
Contributor

vrann commented May 24, 2017

@cmuench thank you, merged!

@magento-team
Copy link
Contributor

@cmuench thank you for your contribution to Magento 2 project

@cmuench
Copy link
Contributor Author

cmuench commented May 25, 2017

@miguelbalparda There is no PDF download link available in the frontend area. If we will add a download link in the future to Magento frontend we would have an issue without this changes.
We had already an issue in one of our projects, because we create a PDF file programmatically via a cronjob by using store emulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants