[feature]: Add the possibility to allow certain packages to change code outside their namespace #3156
Comments
|
Hi @Jordaneisenburger. Thank you for your report. Please, add a comment to assign the issue:
|
|
@magento export issue to JIRA project PWA as Story |
|
✅ Jira issue https://jira.corp.magento.com/browse/PWA-1702 is successfully created for this GitHub issue. |
|
Is it possible for me to take a look into this and create a PR for this issue? I would also like to have this feature, but i'm not sure on how the core team thinks about this enhancement? |
|
@jerschipper we welcome contributions! If you'd like to give it a shot, please do, and let us know that you are working on it. |
|
@jerschipper are you still working on this? |
|
@sirugh I really would like to do this. But i'm having trouble finding the correct time for it. How do you think about this modification @sirugh ? |
github-jira-sync-bot
added
Progress: PR approved
Progress: PR review
and removed
Progress: PR review
Progress: PR approved
labels
…ir namespace (#3156) (#3266) * Added possibility to allow trusted vendors to change code outside their namespace (#3156) * Read trusted vendors from root project package.json * Checking if package.json exists (Wrong context in some tests) * Rename trusted_vendors to trusted-vendors * use process.cwd instead of hard context * Run prettier Co-authored-by: Lars Roettig <l.roettig@techdivision.com> Co-authored-by: Tommy Wiebell <twiebell@adobe.com>
Is your feature request related to a problem? Please describe.
As an agency we sometimes need to change
@magento/packagecode from within our own packages@experius/packageas an example we need to change the way a part of pwa studio works or do a bugfix that's not yet in the current released version of PWA Studio.A more concrete example would be this bugfix to the core. It's merged but wasn't shipped with 10.0. So I'd like to patch this file with a targetable for our projects from within our own package
@experius/uiUnfortunately this isn't allowed, we either need to have the same namspace
@magento/peregrineor be inside the local project. This safety check is added for security reasons. But it's also limiting to agencies because we don't want to maintain default (meaning we need this for all our projects) targetables on 20 different projects inside the customers source.Describe the solution you'd like
I'd love to see a way where the developer can explicitly tell webpack to also allow package x,y and z to change code from other packages. This way we are much more flexible but still keep the security as tight since the developer needs to manually allow a certain package in their local project's webpack.
Describe alternatives you've considered
Additional context
Please let us know what packages this feature is in regards to:
venia-conceptvenia-uipwa-buildpackperegrinepwa-devdocsupward-jsupward-speccreate-pwaThe text was updated successfully, but these errors were encountered: