Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] CICD - Establish feature parity with CircleCI in AWS CodeBuild/CodePipeline #925

Closed
sharkySharks opened this issue Feb 19, 2019 · 3 comments
Closed

[FEATURE] CICD - Establish feature parity with CircleCI in AWS CodeBuild/CodePipeline #925

sharkySharks opened this issue Feb 19, 2019 · 3 comments
Assignees
@sharkySharks
Labels
enhancement New feature or request
Milestone
Next PWA Release ...

Comments

@sharkySharks
Copy link
Contributor

sharkySharks commented Feb 19, 2019 •
edited

First step for this story is to reach feature parity with CircleCI in CodeBuild.
All commands running in CircleCI should run successfully in codebuild and report status back to GitHub.
@sharkySharks sharkySharks added the enhancement New feature or request label Feb 19, 2019
@sharkySharks sharkySharks self-assigned this Feb 19, 2019
@sharkySharks sharkySharks mentioned this issue Feb 19, 2019
Closed
2 tasks
@sharkySharks sharkySharks changed the title [FEATURE] CICD - Stand up Jenkins instance for PWA CI activity [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild Mar 6, 2019
@sharkySharks sharkySharks added the hold On hold until another condition is fulfilled. label Mar 12, 2019
@sharkySharks
Copy link
Contributor Author

On hold, pending infrastructure review and decision from management.

@sharkySharks sharkySharks removed the hold On hold until another condition is fulfilled. label Mar 18, 2019
@sharkySharks sharkySharks changed the title [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild in PR builds Mar 18, 2019
@sharkySharks sharkySharks changed the title [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild in PR builds [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild Mar 19, 2019
@sharkySharks sharkySharks changed the title [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild for PRs Mar 19, 2019
@sharkySharks sharkySharks changed the title [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild for PRs [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild/CodePipeline for PRs Mar 19, 2019
@sharkySharks
Copy link
Contributor Author

Discovered that Danger has support for CodeBuild built in, but DangerJS has not ported that functionality over yet. I submitted a pull request to DangerJS to add this functionality. For now I have injected the needed CodeBuild DangerJS scripts in post install after building them locally with success.

@sharkySharks
Copy link
Contributor Author

sharkySharks commented Mar 22, 2019 •
edited

Tracking Danger JS pull request for adding CodeBuild support: danger/danger-js#844 - merged ✅

@sharkySharks sharkySharks mentioned this issue Mar 29, 2019
Merged
@sharkySharks sharkySharks changed the title [FEATURE] CICD - Migrate from CircleCI to AWS CodeBuild/CodePipeline for PRs [FEATURE] CICD - Establish feature parity with CircleCI in AWS CodeBuild/CodePipeline Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharkySharks sharkySharks

Labels
enhancement New feature or request
Projects
None yet
Milestone
Next PWA Release (Core 2.3.2)
Development

No branches or pull requests
3 participants
@sharkySharks @dpatil-magento @cherdman