Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Dockerfile for production build of PWA #940

Closed
sharkySharks opened this issue Feb 22, 2019 · 6 comments
Closed

Create Dockerfile for production build of PWA #940

sharkySharks opened this issue Feb 22, 2019 · 6 comments
Assignees
@sharkySharks
Labels
enhancement New feature or request
Milestone
Next PWA Release ...

Comments

@sharkySharks
Copy link
Contributor

Need to have a PWA production instance for demo purposes. The first step in this process includes creating a docker image that serves PWA from a production server. The current docker setup uses the development server for serving the application, ie webpack-dev-server, and cannot be used to run the application as the magento instance, https://m230-pwa-ent-0.testsonfire.com/, is set to production mode and therefore conflicts with local development and query verification mode.

A proposal for a production build is to utilize the node server.js command to run the application with node and proxy it through nginx or another layer in order to handle web traffic and add additional monitoring of at least a /healthz endpoint.

This will use the upward-js module; a separate effort will be needed to serve the application using upward-php in the future.
@sharkySharks sharkySharks self-assigned this Feb 22, 2019
@sharkySharks sharkySharks changed the title Create Docker production deploy environment Create Dockerfile for production build of PWA Mar 11, 2019
@sharkySharks
Copy link
Contributor Author

This work is complete but will ship together with #587 to see full end to end functionality.

@sharkySharks sharkySharks added the hold On hold until another condition is fulfilled. label Mar 14, 2019
@sharkySharks
Copy link
Contributor Author

Work completed, adding hold label - waiting on #859 to be merged.

@sharkySharks
Copy link
Contributor Author

nginx layer is not necessary at this moment as the "production" build is for demo purposes only and will not be handling a lot of web traffic. Health monitoring alerts can be turned on in Elastic Beanstalk.

@sharkySharks sharkySharks removed the hold On hold until another condition is fulfilled. label Mar 21, 2019
@sharkySharks
Copy link
Contributor Author

Removing HOLD after #859 merge.

@sharkySharks sharkySharks mentioned this issue Mar 21, 2019
Closed
@sharkySharks sharkySharks added the hold On hold until another condition is fulfilled. label Mar 21, 2019
@sharkySharks
Copy link
Contributor Author

Adding HOLD label, waiting on #1012 to create pull request.

@sharkySharks sharkySharks mentioned this issue Mar 29, 2019
Merged
@sharkySharks sharkySharks removed the hold On hold until another condition is fulfilled. label Mar 29, 2019
@sharkySharks
Copy link
Contributor Author

PR: #1087

@sharkySharks sharkySharks added the enhancement New feature or request label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharkySharks sharkySharks

Labels
enhancement New feature or request
Projects
None yet
Milestone
Next PWA Release (Core 2.3.2)
Development

No branches or pull requests
3 participants
@sharkySharks @dpatil-magento @cherdman