Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --insecure flag to GraphQL schema validation #1313

Merged
merged 2 commits into from Jun 11, 2019

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented Jun 7, 2019

Description

Add --insecure flag to download-schema script.

Related Issue

Closes #1311

Verification Steps

  1. Setup Magento backend with self-signed or insecure cert
  2. yarn build
  3. Build successful

How have YOU tested this?

Ran the verification steps

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Jun 7, 2019
@vercel
Copy link

vercel bot commented Jun 7, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-bug-insecure-query-validation.magento-research1.now.sh

Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@PWAStudioBot
Copy link
Contributor

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against a579165

@dpatil-magento dpatil-magento merged commit 3b50420 into develop Jun 11, 2019
@supernova-at supernova-at deleted the bug/insecure-query-validation branch July 25, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-concept version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Query Validation Doesn't Support Insecure Backends
4 participants