[doc] Update usage of UI Component #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
pkg:pwa-devdocs
documentation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-jimothy-gh-1396replace-ui-component-term-usage.magento-research1.now.sh |
|
supernova-at
requested changes
Jul 25, 2019
|
|
||
| Currently, the Peregrine package is the only project set up to use Storybook as a development and testing environment for its UI components. | ||
| Currently, the Peregrine package is the only project set up to use Storybook as a development and testing environment for its components. |
There was a problem hiding this comment.
This is not actually true, Venia has a storybook too.
There was a problem hiding this comment.
Ah, I see. This topic needs a revision anyways. Will add it to the backlog.
| @@ -136,5 +135,5 @@ This command starts the Storybook application that is accessed through the brows | |||
| http://localhost:9001/ | |||
| ``` | |||
|
|
|||
| [Storybook]: https://storybook.js.org/ | |||
| [official Storybook documentation]: https://storybook.js.org/basics/introduction/ | |||
| [storybook]: https://storybook.js.org/ | |||
There was a problem hiding this comment.
Does it matter that the casing here doesn't match the link on line 5?
There was a problem hiding this comment.
it does not matter in markdown, but one of my linting rules is that all link references be in all lowercase.
Co-Authored-By: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
supernova-at
approved these changes
Jul 25, 2019
dpatil-magento
deleted the
jimothy/gh-1396_replace-ui-component-term-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates references to Peregrine as a "UI Component" library.
This PR also fixes linting issues in affected, published topics.
Related Issue
Closes #1396
Verification Steps
pwa-devdocsdirectorynpm run developScreenshots / Screen Captures (if appropriate)
n/a
Checklist: