Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed in customer access to create account page #1548

Closed
wants to merge 9 commits into from
Closed

Signed in customer access to create account page #1548

wants to merge 9 commits into from

Conversation

gaurav-473
Copy link
Contributor

@gaurav-473 gaurav-473 commented Aug 11, 2019

Issue #1549 Fixed (Sign in customer access create account page)

Description

  1. Sign in with customer detail .
  2. Now open create account page
  3. You are able to access create account page . Which is wrong customer need to redirect on home page or my account section.

Verification Steps

  1. Sign in with customer detail .
  2. Now open create account page
  3. Now customer redirect to homepage.

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Closes #1549

@magento-cicd2
Copy link

magento-cicd2 commented Aug 11, 2019

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Aug 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://pwa-studio-git-fork-gauravagarwal1001-develope-pr.mmansoor.now.sh

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 11, 2019
@gaurav-473 gaurav-473 changed the title Develope pr Issue Fixed (Sign in customer access create account page) Aug 11, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Aug 11, 2019

Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against 32ae08e

@vercel vercel bot temporarily deployed to staging August 11, 2019 16:48 Inactive
@gaurav-473 gaurav-473 changed the title Issue Fixed (Sign in customer access create account page) Issue #1549 Fixed (Sign in customer access create account page) Aug 11, 2019
@supernova-at supernova-at changed the title Issue #1549 Fixed (Sign in customer access create account page) Signed in customer access to create account page Aug 12, 2019
@supernova-at
Copy link
Contributor

Hi @gauravagarwal1001 , I am having some trouble reproducing this issue.

  1. Sign in with customer detail .
  2. Now open create account page

From https://magento-venia-develop.now.sh/ (the latest develop code) can you provide a screenshot that shows how to access the create account page after I am signed in?

Once I am signed in I no longer can access the create account page.

Thanks!

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 12, 2019
@magento magento deleted a comment from PWAStudioBot Aug 12, 2019
@gaurav-473
Copy link
Contributor Author

Hi @gauravagarwal1001 , I am having some trouble reproducing this issue.

  1. Sign in with customer detail .
  2. Now open create account page

From https://magento-venia-develop.now.sh/ (the latest develop code) can you provide a screenshot that shows how to access the create account page after I am signed in?

Once I am signed in I no longer can access the create account page.

Thanks!

After signed in you can directly access create account page with this link
https://magento-venia-develop.now.sh/create-account

Below is the screenshot .. Signed in customer access create account page.
error

@supernova-at supernova-at self-assigned this Aug 12, 2019
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 12, 2019
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing this!

One minor update and this will be good to go.

@supernova-at
Copy link
Contributor

Hi @gauravagarwal1001, there were some venia refactors that just got merged and so this PR has some conflicting files. Please let us know if you're unsure how to resolve the conflicts.

@gaurav-473
Copy link
Contributor Author

Hi @gauravagarwal1001, there were some venia refactors that just got merged and so this PR has some conflicting files. Please let us know if you're unsure how to resolve the conflicts.

Yes I don't know what's the conflicts in this files.. How to check conflicts of these files ?

@sirugh
Copy link
Contributor

sirugh commented Aug 14, 2019

@gauravagarwal1001 Most everything was moved to venia-ui/. You should be able to move the two files from venia-concept/src/* to venia-ui/lib/*.

@gaurav-473
Copy link
Contributor Author

gaurav-473 commented Aug 14, 2019

@gauravagarwal1001 Most everything was moved to venia-ui/. You should be able to move the two files from venia-concept/src/* to venia-ui/lib/*.

Thanks I created new pr #1559 .. Please review this one

@sirugh sirugh closed this Aug 14, 2019
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Request Progress Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-concept Progress: review version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Sign in customer access create account page
6 participants