-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed in customer access to create account page #1548
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://pwa-studio-git-fork-gauravagarwal1001-develope-pr.mmansoor.now.sh |
|
Hi @gauravagarwal1001 , I am having some trouble reproducing this issue.
From https://magento-venia-develop.now.sh/ (the latest Once I am signed in I no longer can access the create account page. Thanks! |
After signed in you can directly access create account page with this link Below is the screenshot .. Signed in customer access create account page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and fixing this!
One minor update and this will be good to go.
Hi @gauravagarwal1001, there were some venia refactors that just got merged and so this PR has some conflicting files. Please let us know if you're unsure how to resolve the conflicts. |
Yes I don't know what's the conflicts in this files.. How to check conflicts of these files ? |
@gauravagarwal1001 Most everything was moved to |
Thanks I created new pr #1559 .. Please review this one |
Issue #1549 Fixed (Sign in customer access create account page)
Description
Verification Steps
Proposed Labels for Change Type/Package
Closes #1549