Fixed a bug where the post-install script would suggest to setup a cu… #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
…stom origin when the project was already setup like this. (magento#1731)
LukasKiederle
force-pushed
the
develop
branch
from
201f81c
to
e3282b9
Compare
zetlen
added
the
version: Patch
zetlen
approved these changes
Sep 21, 2019
m2-community-project
bot
moved this from Ready for Review
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stom origin when the project was already setup like this (#1731)
Closes #1731
Description
I changed the relativ path to the project to an absolute path because the hash which is used for comparison would not lead to the expected result.
Running
yarn installon an already installed instance will not lead to this console output anymore:Please run Set up a custom origin for your copy of venia-concept: yarn buildpack create-custom-origin packages/venia-concept. )