Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout These Talons! #1775

Merged
merged 11 commits into from Sep 30, 2019
Merged

Checkout These Talons! #1775

merged 11 commits into from Sep 30, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Sep 24, 2019 •
edited

Description

Talon-ized the checkout components. I did not add much documentation because IMO we should refactor checkout to use context. At that time the props being passed around will be greatly reduced in number making docs not a pain in the rear to write.

Components not being "talonized". I didn't do these for reasons. Most of them are just display logic but I wasn't sure about BraintreeDropin.

  Form
  Label
  Section
  BraintreeDropin (crazy?) I think this is something very custom/confusing -- people will probably roll their own or just use ours wholesale w/ no customization
  *Summary (too simple?) These don't have much functionality beyond display

Acceptance

Verification Stakeholders

@jimbo

Verification Steps

Regression test checkout. Authed and unauthed.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Sep 24, 2019
@sirugh sirugh requested a review from jimbo September 24, 2019 20:57
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Sep 24, 2019 •
edited

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or including the associated JIRA ID in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against ade1ba7

jimbo
jimbo suggested changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on a couple things I noticed on my way through the first few files. Let's discuss before proceeding.

packages/peregrine/lib/talons/Checkout/Receipt/useReceipt.js
import { useAppContext } from '@magento/peregrine/lib/context/app';

export const useReceipt = props => {
// TODO replace with useHistory from Router 5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

packages/peregrine/lib/talons/Checkout/useAddressForm.js Outdated Show resolved Hide resolved
packages/peregrine/lib/talons/Checkout/useAddressForm.js Show resolved Hide resolved
packages/peregrine/lib/talons/Checkout/useFlow.js Show resolved Hide resolved
packages/peregrine/lib/talons/Checkout/useFlow.js
cartState,
checkoutDisabled: isSubmitting || cartState.isEmpty,
checkoutState,
isReady: isCheckoutReady(checkoutState),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. 👍

@m2-community-project m2-community-project bot moved this from Ready for Review to Changes Requested in Pull Request Progress Sep 24, 2019
@m2-community-project m2-community-project bot moved this from Changes Requested to Review in Progress in Pull Request Progress Sep 24, 2019
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 25, 2019
jimbo
jimbo reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I only have the one question about what happened to the Cart component. This will really help open up checkout customization. 👍

packages/peregrine/lib/talons/Checkout/usePaymentsFormItems.js Outdated Show resolved Hide resolved
sirugh
sirugh commented Sep 26, 2019
View reviewed changes
packages/peregrine/package.json
@@ -30,6 +30,7 @@
},
"peerDependencies": {
"@babel/runtime": "~7.4.2",
"informed": "~2.1.13",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have updated the yarn lock. 🤷‍♂

@dpatil-magento dpatil-magento moved this from Review in Progress to Reviewer Approved in Pull Request Progress Sep 30, 2019
@dpatil-magento dpatil-magento moved this from Reviewer Approved to QA In Progress in Pull Request Progress Sep 30, 2019
@dpatil-magento dpatil-magento merged commit c06e51b into develop Sep 30, 2019
@dpatil-magento dpatil-magento deleted the rugh/checkout-these-talons branch September 30, 2019 19:03
@m2-community-project m2-community-project bot moved this from QA In Progress to Done in Pull Request Progress Sep 30, 2019
@jimbo jimbo mentioned this pull request Oct 2, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbo jimbo jimbo approved these changes

Assignees

@sirugh sirugh

@jimbo jimbo

Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sirugh @PWAStudioBot @jimbo @dpatil-magento