Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add MBI to search and update site switcher #2001

Merged
merged 2 commits into from Dec 3, 2019
Merged

[docs] Add MBI to search and update site switcher #2001

merged 2 commits into from Dec 3, 2019

Conversation

belbiy
Copy link
Contributor

@belbiy belbiy commented Nov 22, 2019

Description

This pull request (PR) add MBI User Guide to federated search and update the link in site switcher.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to documentation home page.
  2. Search type search query
  3. Hit enter
  4. See that MBI User Guide results are showing

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Nov 22, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Nov 22, 2019 •
edited

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 7732b8d

@belbiy belbiy changed the title Add MBI to search and update site switcher [docs] Add MBI to search and update site switcher Nov 22, 2019
@revanth0212
Copy link
Contributor

@jcalcaben

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Nov 25, 2019
@jcalcaben jcalcaben merged commit 5dbdc20 into magento:develop Dec 3, 2019
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbo jimbo jimbo approved these changes

@jcalcaben jcalcaben jcalcaben approved these changes

Assignees

@jimbo jimbo

@jcalcaben jcalcaben

Labels
None yet
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@belbiy @PWAStudioBot @revanth0212 @jimbo @jcalcaben