Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates template HTML to include noscript fallback #2034

Merged
merged 3 commits into from Dec 17, 2019
Merged

Updates template HTML to include noscript fallback #2034

merged 3 commits into from Dec 17, 2019

Conversation

supernova-at
Copy link
Contributor

@supernova-at supernova-at commented Dec 17, 2019 •
edited

Description

When we switched away from Mustache templates, we accidentally lost our fallback for when JavaScript is disabled.

This PR adds it back.

It copies (and slightly modifies) the now-unused js-unavailable mustache template and adds it directly to the new single template.html.

Related Issue

Closes JIRA-218.

Acceptance

Verification Stakeholders

@revanth0212

Specification

Verification Steps

  1. Disable JavaScript in your browser
  2. Reload Venia
  3. See that you are presented with the fallback UI

Screenshots / Screen Captures (if appropriate)

Mobile

Screen Shot 2019-12-17 at 11 36 08 AM

Desktop

Screen Shot 2019-12-17 at 11 36 41 AM

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 17, 2019
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Dec 17, 2019 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: JIRA-218.

Generated by 🚫 dangerJS against 890082c

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Dec 17, 2019
sirugh
sirugh reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay it's functionally non functional again!

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Dec 17, 2019
@dpatil-magento dpatil-magento merged commit cc2ef38 into develop Dec 17, 2019
@dpatil-magento dpatil-magento deleted the supernova/218_nojs branch December 17, 2019 21:23
@m2-community-project m2-community-project bot moved this from Review in Progress to Done in Pull Request Progress Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh approved these changes

Assignees

@sirugh sirugh

Labels
pkg:venia-concept version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@supernova-at @PWAStudioBot @sirugh @dpatil-magento