Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-261] [SAFARI][DESKTOP][CLOUD] Default swatch image ratio is not proper on product details page #2055

Merged
merged 4 commits into from Jan 7, 2020

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented Jan 6, 2020

Description

URL - /valeria-two-layer-tank.html

/valeria-two-layer-tank.html

-Steps –

Hit any of the above cloud deployed URL in SAFARI browser on desktop.
Observe the first default swatch image.
Corrected Steps (if you don't see behavior, be sure to clear all caches)

Navigate to Category page to preload thumbnail images (/venia-tops.html)
Then navigate to a PDP (/vitalia-top.html)
Observe aspect ratio of thumbnail and main image (appears to be serving from service worker cache, then applying cropping again)
Expected - All swatch images should have right ratio.

Actual - First swatch image ration is not proper.

Note -

  1. Works fine on 4.0.0 Magento Cloud https://venia.magento.com/

  2. Works fine on 5.0.0 AWS deployed instances (https://pr-2043.pwa-venia.com/valeria-two-layer-tank.html). Issue only with Magento Cloud deployments.

Related Issue

  • [PWA-261] [SAFARI][DESKTOP][CLOUD] Default swatch image ratio is not proper on product details page

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Start Venia with Service Workers enabled, a Fastly backend, and IMAGE_OPTIMIZING_ORIGIN=backend
  2. Follow steps in description for repro and verify issue no longer exists
  3. Navigate around other pages with images and verify no regressions introduced with image aspect ratio

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 6, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-261.

Generated by 🚫 dangerJS against 0bc0af7

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Jan 6, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Changes Requested in Pull Request Progress Jan 6, 2020
- Replace usage of resourceUrl with newly exported utility
- Update tests
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Jan 7, 2020
@dpatil-magento dpatil-magento merged commit 9eee4d2 into release/5.0 Jan 7, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jan 7, 2020
@dpatil-magento dpatil-magento deleted the tommy/safari-src-bug branch January 7, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants