Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added update-site-footer tutorial doc #2065

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

rossmc
Copy link
Contributor

@rossmc rossmc commented Jan 7, 2020

Description

Add update-site-footer doc for new tutorial series to help beginners (#2021)

Related Issue

Closes #2064 .

Acceptance

Verification Stakeholders

@jcalcaben

Specification

Add Tutorial Doc

Verification Steps

  1. Review pwa-devdocs/_drafts/pwa-studio-fundamentals/update-site-footer

Screenshots / Screen Captures (if appropriate)

update-site-footer

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 7, 2020

Fails
🚫 A version label is required. A maintainer must add one.
🚫 Issue 2064 is closed. Please make sure the linked issue is correct and open.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 57cb0c7

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 4, 2020
@dpatil-magento dpatil-magento merged commit dfcb231 into magento:develop Feb 5, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[doc]: Add a update-site-footer doc in new tutorial series for beginners
5 participants