Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added component-state tutorial doc #2071

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

rossmc
Copy link
Contributor

@rossmc rossmc commented Jan 7, 2020

Description

Add component-state doc for new tutorial series to help beginners (#2021)

Related Issue

Closes #2070.

Acceptance

Verification Stakeholders

@jcalcaben

Specification

Add Tutorial Doc

Verification Steps

  1. Review pwa-devdocs/_drafts/pwa-studio-fundamentals/component-state

Screenshots / Screen Captures (if appropriate)

component-state-v2

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 7, 2020

Fails
🚫 A version label is required. A maintainer must add one.
🚫 Issue 2070 is closed. Please make sure the linked issue is correct and open.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against be7e9ab

@brendanfalkowski
Copy link
Contributor

Would it be better to write this in function components and hooks since most of PWA Studio isn't using class components anymore?

@rossmc
Copy link
Contributor Author

rossmc commented Jan 8, 2020

Would it be better to write this in function components and hooks since most of PWA Studio isn't using class components anymore?

Very good point @brendanfalkowski. I originally wrote these before PWA Studio started using hooks. I had been meaning to update but forgot.

I'll update shortly for this doc and others. Thanks :)

cc @jcalcaben

@rossmc
Copy link
Contributor Author

rossmc commented Jan 8, 2020

c1d75a6 - updated tutorial doc to demonstrate functional component & hooks

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 4, 2020
@dpatil-magento dpatil-magento merged commit d746165 into magento:develop Feb 5, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[doc]: Add a component-state doc in new tutorial series for beginners
6 participants