Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added manage-state-with-redux tutorial doc #2079

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

rossmc
Copy link
Contributor

@rossmc rossmc commented Jan 7, 2020

Description

Add manage-state-with-redux doc for new tutorial series to help beginners (#2021)

Related Issue

Closes #2078.

Acceptance

Verification Stakeholders

@jcalcaben

Specification

Add Tutorial Doc

Verification Steps

  1. Review pwa-devdocs/_drafts/pwa-studio-fundamentals/manage-state-with-redux

Screenshots / Screen Captures (if appropriate)

manage-state-with-redux-v2

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 7, 2020

Fails
🚫 Issue 2078 is closed. Please make sure the linked issue is correct and open.
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 62b5ca6

@jcalcaben
Copy link
Contributor

@rossmc This may need to be updated since PWA Studio now provides state data through context hooks: https://github.com/magento/pwa-studio/tree/develop/packages/peregrine/lib/context

Let me know if you don't have the bandwidth to do the update.
I can still accept this as-is since it's just a draft, but I will need to update the majority of the content before publishing.

@rossmc
Copy link
Contributor Author

rossmc commented Jan 14, 2020

@jcalcaben I wasn't aware of context hooks, thanks! I need to research them a bit :)

I probably won't get a chance to look at it for next week or two.

Happy for you to accept as-is.

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 4, 2020
@dpatil-magento dpatil-magento merged commit e47aba1 into magento:develop Feb 5, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[doc]: Add a manage-state-with-redux doc in new tutorial series for beginners
5 participants