Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button section to the styleguide #2088

Merged
merged 6 commits into from
Jan 17, 2020
Merged

Add a button section to the styleguide #2088

merged 6 commits into from
Jan 17, 2020

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Jan 8, 2020 •
edited

Description

Add a button section to the styleguide. Some of the prose content may be lorem ipsum, but the values should reflect the official Venia styles.

Related Issue

PWA-154

Acceptance

  • @jcalcaben should affirm document structure
  • @soumya-ashok should affirm Venia typographic styles
  • Others may review the code

Verification Stakeholders

Specification

Verification Steps

  1. yarn workspace @magento/venia-styleguide run start
  2. Navigate to /page/button

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have not added tests to cover my changes, if necessary.

@jimbo jimbo added in progress version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jan 8, 2020
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jan 8, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 8, 2020 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-154.

Generated by 🚫 dangerJS against 744b834

@jimbo
Copy link
Contributor Author

jimbo commented Jan 9, 2020

A bit of strangeness going on with the lockfile on this one. Will have to look into it.

@jimbo jimbo removed the in progress label Jan 9, 2020
revanth0212
revanth0212 previously approved these changes Jan 10, 2020
View reviewed changes
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jan 10, 2020
@revanth0212
Copy link
Contributor

Approved.

Once you fix the tests, it will be ready to be merged.

@revanth0212 revanth0212 mentioned this pull request Jan 10, 2020
Merged
@jimbo jimbo dismissed revanth0212’s stale review January 17, 2020 18:57

The base branch was changed.

@jimbo jimbo changed the base branch from jimbo/styleguide-color to develop January 17, 2020 18:57
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Jan 17, 2020
@jimbo jimbo merged commit 31d1093 into develop Jan 17, 2020
@m2-community-project m2-community-project bot moved this from Review in Progress to Done in Pull Request Progress Jan 17, 2020
@jimbo jimbo deleted the jimbo/styleguide-buttons branch January 17, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revanth0212 revanth0212 revanth0212 approved these changes

Assignees

@revanth0212 revanth0212

Labels
pkg:peregrine pkg:venia-styleguide version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimbo @PWAStudioBot @revanth0212