Adjust cart styling #2104
Merged
Adjust cart styling #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimbo
added
the
version: Patch
|
supernova-at
previously approved these changes
Jan 17, 2020
There was a problem hiding this comment.
I think we could delete the temporary styles for the scrollable summary in cartPage.css, but @tjwiebell 's got that feature coming online soon anyway so no biggie
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
supernova-at
previously approved these changes
Jan 17, 2020
sirugh
reviewed
Jan 17, 2020
| @@ -1,13 +1,13 @@ | |||
| .root { | |||
| padding-top: 1.5rem; | |||
| max-width: 64rem; | |||
| padding: 2.5rem 3rem; | |||
There was a problem hiding this comment.
I think 3rem is overkill on mobile.
There was a problem hiding this comment.
It is. I see you've set it to 1.5rem, and that works. It may be able to go as low as 1rem.
m2-community-project
bot
moved this from Reviewer Approved
to Review in Progress
in Pull Request Progress
Signed-off-by: Stephen Rugh <rugh@adobe.com>
supernova-at
approved these changes
Jan 17, 2020
m2-community-project
bot
moved this from Review in Progress
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make minor adjustments to cart page styling to better fit design intent and existing views.
Related Issue
PWA-241
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist