Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for ErrorView #1308 #2116

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Refactoring for ErrorView #1308 #2116

merged 2 commits into from
Jan 29, 2020

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented Jan 25, 2020

Description

Add a better scalable ErrorView as mentation from @jimbo in #2110 (review)

Related Issue

Closes #1308

Acceptance

So if you'd like to repurpose ErrorView as a generic component, would you consider rewriting it to simply render props.children and apply some styles? That might be something we could use.

Specification

Verification Steps

  1. Open Url: https://magento-venia-concept-yoy6e.local.pwadev:8611/ErrorView
  2. It should show the new styled message

Screenshots / Screen Captures (if appropriate)

image

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 25, 2020

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 14c2d4b

Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsroettig Thanks for addressing feedback on this one, I think we're good here. 👍

I'll enlist UX to help expand on the design at some point in the future.

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jan 29, 2020
@dpatil-magento dpatil-magento merged commit e4c124b into magento:develop Jan 29, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Refactor ErrorView Component (Scalability)
5 participants