Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a better scalable
ErrorView
as mentation from @jimbo in #2110 (review)Related Issue
Closes #1308
Acceptance
So if you'd like to repurpose ErrorView as a generic component, would you consider rewriting it to simply render props.children and apply some styles? That might be something we could use.
Specification
Verification Steps
https://magento-venia-concept-yoy6e.local.pwadev:8611/ErrorView
Screenshots / Screen Captures (if appropriate)
Checklist