Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing defaults and docs for DEV_SERVER_SERVICE_WORKER_ENABLED. #2148

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Changing defaults and docs for DEV_SERVER_SERVICE_WORKER_ENABLED. #2148

merged 2 commits into from
Feb 10, 2020

Conversation

revanth0212
Copy link
Contributor

Description

Changing defaults and docs for DEV_SERVER_SERVICE_WORKER_ENABLED.

Related Issue

Closes JIRA-352

Verification Steps

No changes

Checklist

None

@revanth0212 revanth0212 added the version: Patch This changeset includes backwards compatible bug fixes. label Feb 7, 2020
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Feb 7, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 7, 2020 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: JIRA-352.

Generated by 🚫 dangerJS against 5762827

supernova-at
supernova-at approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/magento/pwa-studio/pull/2155/files

😮

fight

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 10, 2020
@dpatil-magento dpatil-magento merged commit eedd110 into develop Feb 10, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 10, 2020
@dpatil-magento dpatil-magento deleted the revanth/devServerSWEnabledKeyFixes branch February 10, 2020 22:34
@revanth0212 revanth0212 mentioned this pull request Feb 12, 2020
Closed
@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 13, 2020 •
edited

Ok i'm fine with that. You can close mine
@supernova-at haha you are very funny

@awilcoxa awilcoxa mentioned this pull request Mar 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supernova-at supernova-at supernova-at approved these changes

Assignees

@supernova-at supernova-at

Labels
version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@revanth0212 @PWAStudioBot @mrtuvn @supernova-at @dpatil-magento