[PWA-376] Cart page items show correct configurable options #2167
Conversation
tjwiebell
added
the
version: Patch
|
| @@ -42,7 +43,8 @@ export const cacheKeyFromType = object => { | |||
| return object.url_key | |||
| ? `${MagentoGraphQLTypes.ProductInterface}:${object.url_key}` | |||
| : defaultDataIdFromObject(object); | |||
|
|
|||
| case MagentoGraphQLTypes.SelectedConfigurableOption: | |||
There was a problem hiding this comment.
I think a comment here explaining why we have to do this is warranted.
There was a problem hiding this comment.
Also looks like we are getting value_id from the getCartDetails query. I'm not sure that this is just some magical thing we have. We may want to make sure we add it to the product details query within the CartPage/ components
There was a problem hiding this comment.
Man, good catch! I had assumed Apollo automatically injected this key, but I was mistaken. The bug appeared to be fixed because we weren't caching any options, because object.value_id was undefined 🤔
I've now fixed this up in a187f13 so it uses that field if available, and explicitly won't cache if its left out.
m2-community-project
bot
moved this from Ready for Review
to Changes Requested
in Pull Request Progress
m2-community-project
bot
moved this from Changes Requested
to Review in Progress
in Pull Request Progress
| @@ -23,6 +23,7 @@ export const ProductListingFragment = gql` | |||
| configurable_options { | |||
| id | |||
| option_label | |||
| value_id | |||
There was a problem hiding this comment.
Silly enough - we now have two "required" fields. id per validation although it's not actually guaranteed to be unique and value_id because we use it for caching though you'd find no code within CartPage/ that uses it.
m2-community-project
bot
moved this from Review in Progress
to Done
in Pull Request Progress
Description
Configurable Products listed in the MiniCart and new Cart page are showing different values for their configured properties (ex. Fashion Size, Fashion Color).
RCA:
configurable_options.idis not unique based on selected values, so Apollo was not caching any other options after the first.Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
/cartpage and verify that options are correctly displayedScreenshots / Screen Captures (if appropriate)
Checklist