Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] update setup topic #2192

Merged
merged 2 commits into from
Feb 25, 2020
Merged

[Doc] update setup topic #2192

merged 2 commits into from
Feb 25, 2020

Conversation

jcalcaben
Copy link
Contributor

Description

This PR updates the Venia setup topic content to remove the recommendation for a hard coded Magento version. Readers are now directed to the compatibility table.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

@ericerway

Verification Stakeholders

@ericerway

Specification

Verification Steps

  1. Go to the FOO page.
  2. Verify the BAR shows up.
  3. Make sure BAZ does a thing.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@jcalcaben jcalcaben added the version: Patch This changeset includes backwards compatible bug fixes. label Feb 25, 2020
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Feb 25, 2020
@PWAStudioBot
Copy link
Contributor

Fails
🚫 Missing information in PR. Please fill out the "Verification Steps" section.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against bf6d461

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 25, 2020
@dpatil-magento dpatil-magento merged commit 92c2f1e into develop Feb 25, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 25, 2020
@dpatil-magento dpatil-magento deleted the jimothy/update-setup-topic branch February 25, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants