Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Fix broken summarizeEvents function #2194

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Feb 25, 2020

Description

A bug in the summarizeEvents function was causing the dev server to exit when switching branches and/or running yarn install. This occurred because the reducer function had malformed arguments and also because the reducer was incorrectly not returning the accumulator value after modifying it.

Related Issue

Closes PWA-405.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Prereq: in watch-all.js change line 81 to eventBuffer.length >= 1 ? summarizeEvents() : eventBuffer; This will cause the function to run so we can test it.

  1. Run yarn watch:all on this branch.
  2. In a different terminal, switch branches ie git checkout origin/develop~1
  3. Run yarn install
  4. At no point should the watcher have exited.

Screenshots / Screen Captures (if appropriate)

Yay!

Image from Gyazo

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label Feb 25, 2020
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Feb 25, 2020
@sirugh sirugh requested a review from zetlen February 25, 2020 21:01
Signed-off-by: Stephen Rugh <rugh@adobe.com>
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 25, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-405.

Generated by 🚫 dangerJS against 371f1b4

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 26, 2020
@dpatil-magento dpatil-magento merged commit fce67e6 into develop Feb 26, 2020
@dpatil-magento dpatil-magento deleted the rugh/fix-watcher branch February 26, 2020 22:26
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants