[bug]: Fix broken summarizeEvents function #2194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug in the
summarizeEvents
function was causing the dev server to exit when switching branches and/or runningyarn install
. This occurred because the reducer function had malformed arguments and also because the reducer was incorrectly not returning the accumulator value after modifying it.Related Issue
Closes PWA-405.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Prereq: in
watch-all.js
change line 81 toeventBuffer.length >= 1 ? summarizeEvents() : eventBuffer;
This will cause the function to run so we can test it.yarn watch:all
on this branch.git checkout origin/develop~1
yarn install
Screenshots / Screen Captures (if appropriate)
Yay!
Checklist