Shows Error on invalid Product Quantity #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
supernova-at
added
the
version: Patch
sirugh
reviewed
Feb 26, 2020
packages/peregrine/lib/talons/CartPage/ProductListing/useProduct.js
Outdated
Show resolved
Hide resolved
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
jimbo
approved these changes
Mar 2, 2020
m2-community-project
bot
moved this from Review in Progress
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pops up an error toast when a user enters a number into the product quantity stepper on the cart page that results in a graphQL error, usually occurring when the number entered exceeds the available stock of the product.
Related Issue
Closes PWA-377.
Acceptance
Verification Stakeholders
@schensley @sirugh
Specification
Verification Steps
/cartpageScreenshots / Screen Captures (if appropriate)
Checklist
Notes / Risks
The error message comes straight from the GraphQL backend. "Qty" isn't a great thing to show an end user, but we don't want to be in the business of massaging these error strings.