Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Owls] PB-422: Extensions utilizing Page Builder as their content creation tool will break with upgrade #2199

Merged
merged 4 commits into from
Mar 2, 2020

Conversation

omiroshnichenko
Copy link
Contributor

Description

We resolved a bug as part of our BiC epic PB-55 which will only be migrated for entities that are declared in our configuration. This means any extension which uses Page Builder as a content creation tool will not be upgraded and thus break. This could use the content to become corrupted if modified by the user without it being migrated. So we reverted bugfix that contains BiC changes

Related Issue

PB-422 Extensions utilizing Page Builder as their content creation tool will break with upgrade

Acceptance

Bugfix should be reverted

Verification Steps

  1. Create Page Builder content with one contained row containing a button.
  2. Duplicate that row and change the appearance from contained to Full Width.
  3. Verify the buttons in each row are not aligned

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 26, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PB-55.

Generated by 🚫 dangerJS against 651dec8

@davemacaulay davemacaulay added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Mar 2, 2020
@davemacaulay davemacaulay merged commit e64b6d7 into magento:develop Mar 2, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Done in Pull Request Progress Mar 2, 2020
@davemacaulay davemacaulay deleted the PB-422 branch June 1, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder version: Minor This changeset includes functionality added in a backwards compatible manner.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants