Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Owls] PB-375: Align video background with embedded video #2201

Merged
merged 5 commits into from
Mar 3, 2020
Merged

[Owls] PB-375: Align video background with embedded video #2201

merged 5 commits into from
Mar 3, 2020

Conversation

omiroshnichenko
Copy link
Contributor

Description

Added support for videos from external sources into PageBuilder content so that I can store video assets on CDN or web-server along with other media assets

Related Issue

PB-375 Align video background with embedded video

Acceptance

  • User sees CDN or web-server video playing on the page

Verification Steps

  1. Create Video content type with video from CDN or web-server
  2. Make sure Video playing on the page

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Feb 28, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 28, 2020 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PB-375.

Generated by 🚫 dangerJS against 48f79db

@davemacaulay davemacaulay self-assigned this Mar 3, 2020
@davemacaulay davemacaulay added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Mar 3, 2020
@magento magento deleted a comment from m2-community-project bot Mar 3, 2020
@davemacaulay davemacaulay merged commit bc8c43f into magento:develop Mar 3, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Done in Pull Request Progress Mar 3, 2020
@davemacaulay davemacaulay deleted the PB-375 branch June 1, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemacaulay davemacaulay davemacaulay approved these changes

Assignees
No one assigned
Labels
pkg:pagebuilder version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omiroshnichenko @PWAStudioBot @davemacaulay