-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added firefox specific css. #2233
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@revanth0212 Thanks for picking this one up; I apologize, I thought it had been assigned to me.
Unfortunately, this doesn't address the root issue, which is that the implementation is relying on display: flex
working on a replaced element (<button>
in this case). Also, we should avoid tricks that attempt to target Firefox specifically.
There are two things to fix with the accordion button here:
<button>
is not a reliable flex container or grid container<div>
is not a valid child of<button>
So we need to change the <div>
to a <span>
and make the <span>
the grid container for the whole element. The <button>
should not contribute much to the layout; it's there purely for accessibility reasons.
✅ Verification steps pass |
Description
Accordion text is not center-aligned in firefox. This is probably because of the way firefox interprets
height
on div. Givingline-height
for divs in firefox fixes the problem.Related Issue
Closes PWA-384
Verification Stakeholders
@jimbo
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist