Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update useCategoryTree.js #2243

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Update useCategoryTree.js #2243

merged 3 commits into from
Mar 31, 2020

Conversation

codynguyen1
Copy link
Member

@codynguyen1 codynguyen1 commented Mar 12, 2020 •
edited

Description

Update isLeaf when category.children_count is Int (not String)

Related Issue

Closes #2241.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Open menu
  2. Check the leaf categories

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Mar 12, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 12, 2020 •
edited

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against 7173f7b

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 31, 2020
supernova-at
supernova-at approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Mar 31, 2020
larsroettig
larsroettig approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dpatil-magento dpatil-magento merged commit a6cfa3c into magento:develop Mar 31, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsroettig larsroettig larsroettig approved these changes

@supernova-at supernova-at supernova-at approved these changes

Assignees

@larsroettig larsroettig

@supernova-at supernova-at

Labels
pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Wrong value type in useCategoryTree
6 participants
@codynguyen1 @PWAStudioBot @larsroettig @supernova-at @tjwiebell @dpatil-magento