[Doc] add static route tutorial #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
the
version: Patch
|
supernova-at
requested changes
Mar 16, 2020
| const Foo = () => { | ||
|
|
||
| useEffect(() => { | ||
| document.title = 'Foo Test Page'; |
There was a problem hiding this comment.
I know this is a simple example for a tutorial but Venia uses react-head to things like this. Here's an example: https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/components/CartPage/cartPage.js#L59.
Not sure if you really want to get into that here though, I might just drop the manipulation of title in this file.
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/add-a-static-route/index.md
Outdated
Show resolved
Hide resolved
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/add-a-static-route/index.md
Outdated
Show resolved
Hide resolved
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/add-a-static-route/index.md
Outdated
Show resolved
Hide resolved
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/add-a-static-route/index.md
Outdated
Show resolved
Hide resolved
| + const CartPage = lazy(() => import('../CartPage')); | ||
| + const CheckoutPage = lazy(() => import('../CheckoutPage')); | ||
| + const CreateAccountPage = lazy(() => import('../CreateAccountPage')); | ||
| + const Search = lazy(() => import('../../RootComponents/Search')); |
There was a problem hiding this comment.
What actually changed with these lazy imports? Am I missing something?
There was a problem hiding this comment.
oops I forgot to actually update it 😅
pwa-devdocs/src/tutorials/pwa-studio-fundamentals/add-a-static-route/index.md
Outdated
Show resolved
Hide resolved
| + import Main from '@magento/venia-ui/lib/components/Main'; | ||
| + import Mask from '@magento/venia-ui/lib/components/Mask'; | ||
| + import MiniCart from '@magento/venia-ui/lib/components/MiniCart'; | ||
| + import Navigation from '@magento/venia-ui/lib/components/Navigation'; |
There was a problem hiding this comment.
Just a thought as I read all of these: should we be doing this in Venia already?
m2-community-project
bot
moved this from Ready for Review
to Changes Requested
in Pull Request Progress
Co-Authored-By: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
m2-community-project
bot
moved this from Changes Requested
to Review in Progress
in Pull Request Progress
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
supernova-at
approved these changes
Mar 17, 2020
m2-community-project
bot
moved this from Review in Progress
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revise and publish a tutorial for adding a new static route based on the intial content contributed by @rossmc
Related Issue
Closes PWA-301
Acceptance
Any developer
Verification Stakeholders
Any develop
Specification
Verification Steps
pwa-docsdirectorynpm run lint src/tutorials/pwa-studio-fundamentals/add-a-static-route/index.mdnpm run developScreenshots / Screen Captures (if appropriate)
Checklist