Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign In / Out Toggle on Cart & Checkout Pages #2258

Merged
merged 8 commits into from
Mar 19, 2020
Merged

Conversation

supernova-at
Copy link
Contributor

@supernova-at supernova-at commented Mar 17, 2020

Description

This PR doesn't do much, honestly 馃槤

It was supposed to add sign in capabilities to the Checkout page but @revanth0212 took care of that in a previous PR.

It simply tidies up a couple minor things for consistency with the Cart page.

Related Issue

Closes PWA-243.

Acceptance

Verification Stakeholders

Specification

Verification Steps

TBD

Cart Page

  1. Verify the Sign In button looks and is placed according to the mockup below
  2. Verify the left nav opens when the Sign In button is clicked
  3. Verify nothing is displayed if the user is already signed in

Checkout Page

  1. Verify the Sign In button looks and is placed according to the mockup below
  2. Verify the left nav opens when the Sign In button is clicked
  3. Verify nothing is displayed if the user is already signed in

Screenshots / Screen Captures (if appropriate)

Cart:
Screen Shot 2020-03-18 at 2 13 59 PM

Checkout:
Screen Shot 2020-03-18 at 2 12 31 PM

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 17, 2020

Messages
馃摉

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

馃摉 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
馃摉

Associated JIRA tickets: PWA-243.

Generated by 馃毇 dangerJS against 879f3a3

@soumya-ashok
Copy link

@supernova-at The mocks have been updated on the JIRA issue per our discussion. Let me know if you have any further questions.

Once a shopper signs-in either from cart or checkout, they would need to go to the account menu to sign out.

The one case we need to think about is if their session times-out and they are signed-out, they would see an empty cart so maybe we need a way to let them know that the cart items will be accessible once they sign-in again?

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 18, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Mar 18, 2020
@tjwiebell tjwiebell merged commit a25a317 into develop Mar 19, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Mar 19, 2020
@tjwiebell tjwiebell deleted the supernova/243_sign_in branch March 19, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants