Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Summary - Fix font size unit #2275

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Order Summary - Fix font size unit #2275

merged 1 commit into from
Mar 23, 2020

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented Mar 23, 2020

Description

Revert change that originated from this comment. We should be using rem's, I think this was a misunderstanding.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Add items to cart
  2. Verify order summary title on mobile is still 20px

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Mar 23, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Mar 23, 2020
@sirugh sirugh merged commit 69864e8 into develop Mar 23, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Mar 23, 2020
@tjwiebell tjwiebell deleted the tommy/summary-rem-fix branch April 28, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants