[bug]: Fix (remove) OOTB tests from scaffold #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sirugh <rugh@adobe.com>
Signed-off-by: sirugh <rugh@adobe.com>
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
sirugh
commented
Apr 7, 2020
| @@ -105,7 +104,8 @@ function createProjectFromVenia({ fs, tasks, options }) { | |||
| delete config.projects.venia; | |||
| fs.outputJsonSync(targetPath, config, { spaces: 2 }); | |||
| }, | |||
| '{CHANGELOG*,LICENSE*,_buildpack/*}': tasks.IGNORE, | |||
| '{CHANGELOG*,LICENSE*,_buildpack,_buildpack/**,**/__tests__,**/__tests__/**}': | |||
There was a problem hiding this comment.
This seems verbose because it is. We need to tell the matcher to ignore contents AND the top-level directory otherwise we end up with a bunch of empty __tests__ folders :)
|
tjwiebell
suggested changes
Apr 8, 2020
m2-community-project
bot
moved this from Review in Progress
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
tjwiebell
added
the
version: Patch
Signed-off-by: sirugh <rugh@adobe.com>
tjwiebell
approved these changes
Apr 9, 2020
m2-community-project
bot
moved this from Changes Requested
to Done
in Pull Request Progress
dpatil-magento
added a commit
that referenced
this pull request
Apr 28, 2020
* Removed cart and checkout routes from 6.0 branch. (#2255) * - Mock version in test so snaps dont fail during releases (#2266) - Fixup regex to handle line breaks * [security] minimist >= 1.2.2 (#2267) * Requires at least minimist 1.2.2 due to security vuln Signed-off-by: sirugh <rugh@adobe.com> * Switches to yarn and requires minimist 1.2.2 for security vuln Signed-off-by: sirugh <rugh@adobe.com> * v6.0.0-alpha.1 * v6.0.0-beta.1 * Jimothy/6.0 release notes (#2279) * Add unsorted PR list * Add items to separate lists * Finish organizing PRs in sections * Finish highlights * Remove entries that were part of previous releases * Update PageBuilder to Page Builder Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * fix(pagebuilder): Html content type unescapes content when GraphQL does not (#2283) Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * [PWA-479] Extension Files Missing From Packages (#2305) * Add extensible files and directories to published packages * Revert version bumps Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * v6.0.0-beta.2 * [bug]: Fix (remove) OOTB tests from scaffold (#2321) * Ignores buildpack and test directories during create-pwa Signed-off-by: sirugh <rugh@adobe.com> * Fix glob pattern to match sub directories AND contents Signed-off-by: sirugh <rugh@adobe.com> * Fixes tests and makes ignore pattern easier to construct Signed-off-by: sirugh <rugh@adobe.com> * [Doc] 6.0 release notes updates (#2323) * Add new PRs to changelog and update compatibility table * Fix wrong entry placement * v6.0.0-beta.3 * v6.0.0-rc.1 * v6.0.0 * Enable cart and checkout routes Co-authored-by: Revanth Kumar Annavarapu <35203638+revanth0212@users.noreply.github.com> Co-authored-by: Tommy Wiebell <twiebell@adobe.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com> Co-authored-by: James Zetlen <jzetlen@adobe.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The out of the box tests were failing to run. The tests that were copied were really internal tests for venia-concept components and were not intended to be scaffolded. There will be a follow-up ticket to add a proper test suite to the scaffolded app.
Related Issue
Closes PWA-476 and closes #2244.
Acceptance
Verification Stakeholders
@luke-denton-aligent @zetlen
Specification
Verification Steps
venia-conceptand there should be notestscript in the scaffoldedpackage.json. As a bonus I also removed the_buildpackdirectory.Screenshots / Screen Captures (if appropriate)
Checklist