[PWA-480] Price summary does not get updated after removing an item. #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sirugh
reviewed
Apr 13, 2020
| @@ -32,6 +32,9 @@ export const useProduct = props => { | |||
| // If a product mutation is in flight, tell the cart. | |||
| setIsCartUpdating(updateItemLoading || removeItemLoading); | |||
| } | |||
|
|
|||
| // Reset updating state on unmount | |||
| return () => setIsCartUpdating(false); | |||
There was a problem hiding this comment.
Should we use the onCompleted callback instead?
https://www.apollographql.com/docs/react/data/mutations/#options
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
sirugh
approved these changes
Apr 13, 2020
sirugh
added
the
version: Patch
m2-community-project
bot
moved this from Review in Progress
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
URL - https://develop.pwa-venia.com/
Steps -
Expected - Price summary should get updated for remaining products.
Actual - Price summary is blank, only labels no values.
Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist