Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkout button props #2334

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fix checkout button props #2334

merged 1 commit into from
Apr 14, 2020

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Apr 14, 2020

No description provided.

@sirugh
oops
5478868 
Signed-off-by: sirugh <rugh@adobe.com>
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Apr 14, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Apr 14, 2020
@jimbo jimbo added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 14, 2020
@PWAStudioBot
Copy link
Contributor

Fails
🚫 Missing "Description" section. Please add it back, with detail.
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 5478868

@jimbo jimbo merged commit e9ea1f0 into develop Apr 14, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Apr 14, 2020
@jimbo jimbo changed the title oops Fix checkout button props Apr 14, 2020
@jimbo jimbo deleted the rugh/oops branch April 14, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbo jimbo jimbo approved these changes

Assignees

@jimbo jimbo

Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sirugh @PWAStudioBot @jimbo