[PWA-496] [bug]: Not loading Magento2 media image in PWA #2339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makeUrl
utility doesn't support backend setups that have a path in them. See #2252 for full description.After this fix, you will still be required to update your
upward.yml
to the path of your media if it isn't in the standard location of/media
. I am comfortable with this, as it should only be necessary in development environments.Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
IMAGE_OPTIMIZING_ORIGIN=onboard
https://instance.test/with-path/
IMAGE_OPTIMIZING_ORIGIN=backend
Screenshots / Screen Captures (if appropriate)
Checklist